POC ability to return object from select field from api #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punkle
commented
Jul 10, 2023
| validation.addError( | ||
| 'must start and end with an alphanumeric character, and contain only alphanumeric characters, hyphens, underscores, and periods. Maximum length is 63 characters.', | ||
| ); | ||
| if (typeof value === 'string') { |
There was a problem hiding this comment.
Perhaps we should be using the parameter's schema to be validating this field.
punkle
commented
Jul 10, 2023
| ); | ||
| if (typeof value === 'string') { | ||
| if (!KubernetesValidatorFunctions.isValidObjectName(value)) { | ||
| validation.addError( |
There was a problem hiding this comment.
Honestly.. I think this check is not correct. I dont see why every string returned from the field must be a valid kubernetes object name. It just seems wrong.
I think this validation should look at the schema type and make sure the javascripts types roughly match up.. e.g. a string type returns a string, a number returns a number, a boolean returns a boolean. etc.
|
Is it possible to test locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC ability to return object from select field from api
I dont know if this even works, I havent tried to run it..
The select field from api field currently validates that the field returns a string with specific characteristics. The idea with this change is to allow any type to be returned from the api to be presented to the scaffolder action steps.
✔️ Checklist
yarn changesetin the root)