Display confluence changes in activity stream

[stephane-mori]

Hello,

I can observe that plugin jira don't allow confluence changes to be displayed with activity stream :
https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-jira/src/api/index.ts#L333

Display this changes could be interresting for me. That's why I want to provide a patch allowing to configure the jiraCard component to display confluence changes with activity stream.

Regards,
Stéphane MORI

[sblausten]

Hi, I'm not sure I understand this change you've made - it seems to just give the option to leave out the tickets param - or rather it makes that the default which seems like a major breaking change.

If you wanted to change the activityStream filter that you linked to you would probably want to pass in some kind of flag here https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-jira/src/components/JiraCard/components/ActivityStream.tsx#L137 to the hook and then add some logic to reduce the filtering if the flag is true. Does that make sense?

[stephane-mori]

Hi, this patch indeed gives the possibility of leaving aside the parameter of the tickets.
As the comment in the getActivityStream function indicates, the ticket filter is made to not display the changes made in Confluence. (https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-jira/src/api/index.ts#L333).
However, I don't want to use this filter when I use the JiraCard component. (https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-jira/src/components/JiraCard/JiraCard.tsx)

The JiraCard component is composed of the ActivityStream component. So in order not to filter according to tickets, I want to add a parameter to the JiraCard component allowing this filter to be ignored on tickets. This is the path I provide by adding the displayConfluenceChanges parameter to the JiraCard component.
This parameter, if not filled in, does not change the default behavior of the component. If specified, the ticket filter is ignored.

[punkle]

@stephane-mori I think it might be a little more clear if you were to add a new option to the getActivityStream function. It could be called "filterConfluenceActivity" and default it to true.. What do you think?

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!