Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWSLambdaOverview.tsx #1044

Closed
wants to merge 1 commit into from
Closed

Update AWSLambdaOverview.tsx #1044

wants to merge 1 commit into from

Conversation

ValberJunior
Copy link

@ValberJunior ValberJunior commented Jul 13, 2023

Bug fix: Plugin problem identifying more than one lambda function by annotation.

print2

print1

According to the documentation, to add more than one function, just separate them with a comma, but when doing so, this error appears:

https://github.com/RoadieHQ/roadie-backstage-plugins/tree/main/plugins/frontend/backstage-plugin-aws-lambda

1 validation error detected: Value 'teste-lambda-start,teste-lambda-stop' at 'functionName' failed to satisfy constraint: Member must satisfy regular expression pattern: (arn:(aws[a-zA-Z-]*)?:lambda:)?([a-z]{2}((-gov)|(-iso(b?)))?-[a-z]+-\d{1}:)?(\d{12}:)?(function:)?([a-zA-Z0-9-.]+)(:($LATEST|[a-zA-Z0-9-]+))?

Taking a look at the core of the plugin, it expects a string in this annotation:

"properties" : {
    "aws.com/lambda-function-name": {"type":"string"}
    }

After:

image
hello, I made some small changes for the plugin to accept more than one function, separated only by a comma.

image

✔️ Checklist

  • Adicionados testes para novas funcionalidades e testes de regressão para correções de bugs - [ ] Conjunto de alterações adicionado (execute yarn changeset na raiz) - [ ] Capturas de tela de antes e depois do anexo (para alterações na interface do usuário) - [ ] Documentação adicionada ou atualizada (se aplicável)

Bug fix: Plugin problem identifying more than one lambda function by annotation.
@Xantier
Copy link
Contributor

Xantier commented Jul 31, 2023

I'm closing this version of these modifications for now. It's better to add all the needed changes at once on PR #1045

@Xantier Xantier closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants