Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonata action sp #1047

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Jsonata action sp #1047

merged 3 commits into from
Jul 18, 2023

Conversation

mbenson
Copy link
Contributor

@mbenson mbenson commented Jul 15, 2023

Correctness and consistency among jsonata-related scaffolder actions. I could not see that a changeset script was in fact enabled in the project (nor can I find it in core Backstage anymore when I know I have created these in the past :/ ).

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@mbenson mbenson requested review from a team as code owners July 15, 2023 18:06
@mbenson mbenson requested a review from punkle July 15, 2023 18:06
@punkle
Copy link
Contributor

punkle commented Jul 17, 2023

@mbenson yarn changeset appears to work for me. Could you tell me what problem you are finding with it?

@punkle
Copy link
Contributor

punkle commented Jul 17, 2023

If you can create a changeset, we can merge this, I think.

…g and consistency wrt capitalization and punctuation
@mbenson
Copy link
Contributor Author

mbenson commented Jul 17, 2023

I forgot to yarn install prior to attempting yarn changeset. 🙄

@Xantier Xantier merged commit 3505b53 into RoadieHQ:main Jul 18, 2023
2 checks passed
@mbenson mbenson deleted the jsonata-action-sp branch July 18, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants