-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: integrate google contacts #31
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I just added the google contacts scope to the app. Can you share a video of using this feature within Roam? I'll need it for the verification process
extension: { | ||
google: { | ||
fetchGoogleCalendar?: (options: any) => Promise<any>; | ||
fetchGoogleContacts?: () => Promise<FormattedContact[]>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdroidian let's follow up this PR to add it to where the rest are declared in roamjs-components, then delete from here
Thanks for adding the scope @dvargas92495 ! Trying to log in with the extension on my dev branch to test and I keep getting this error. Thankfully signing in with the version on Roam Depot still works. |
@mdroidian we will also need to make a change here to ensure we only add this query param when Edit: Agh actually, we can't rebase the latest roamjs-components until the samepage cutover is done. Let's make ^ change to the patch-package |
Working to quickly add support for Google Contacts. This would be very helpful for RoamCRM.
This PR is still a WIP because I don't have access to the Google Cloud Console for the extension.
I believe the scope
https://www.googleapis.com/auth/contacts.readonly
would need to be added for me to test.Would you be willing to add that scope?