Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: integrate google contacts #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

8bitgentleman
Copy link

Working to quickly add support for Google Contacts. This would be very helpful for RoamCRM.

This PR is still a WIP because I don't have access to the Google Cloud Console for the extension.

I believe the scope https://www.googleapis.com/auth/contacts.readonly would need to be added for me to test.

Would you be willing to add that scope?

Copy link
Collaborator

@dvargas92495 dvargas92495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I just added the google contacts scope to the app. Can you share a video of using this feature within Roam? I'll need it for the verification process

extension: {
google: {
fetchGoogleCalendar?: (options: any) => Promise<any>;
fetchGoogleContacts?: () => Promise<FormattedContact[]>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdroidian let's follow up this PR to add it to where the rest are declared in roamjs-components, then delete from here

@8bitgentleman
Copy link
Author

8bitgentleman commented Sep 1, 2024

Thanks for adding the scope @dvargas92495 ! Trying to log in with the extension on my dev branch to test and I keep getting this error.
image

Thankfully signing in with the version on Roam Depot still works.
Do you know if there some verification period or process that google needs to go through? Maybe my account isn't considered a test user or somthing?

@dvargas92495
Copy link
Collaborator

@mdroidian we will also need to make a change here to ensure we only add this query param when url.host.includes( 'roamjs') - we should rebase both changes to this PR before merging

Edit: Agh actually, we can't rebase the latest roamjs-components until the samepage cutover is done. Let's make ^ change to the patch-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants