Update to API v2, refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdroidian
commented
Jan 27, 2024
src/index.ts
Outdated
Comment on lines
125
to
127
| date: formattedDate, // TODO - need more data | ||
| startDate: formattedDate, | ||
| endDate: formattedDate, |
There was a problem hiding this comment.
Previous version had start/end as same date, but currently I need different dates to return data. But I only have a few hours of data. Waiting for more to test.
There was a problem hiding this comment.
Inconsistent.
daily_sleep and daily_readiness gave a response with a single date (2024-01-27)
sleep and daily_activity responded with null for a single date, but proper data when two dates were used (2024-01-27 and 2024-01-28)
dvargas92495
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant docs:
https://cloud.ouraring.com/v2/docs
https://partnersupport.ouraring.com/hc/en-us/articles/19907726838163-Oura-API-V2-Upgrade-Guide
requires: samepage-network/samepage.network#125