Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: support images in markdown #251

Merged
merged 6 commits into from
Sep 22, 2022
Merged

New feature: support images in markdown #251

merged 6 commits into from
Sep 22, 2022

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Sep 22, 2022 •
edited
Loading

Fixes #248

Example of rendered HTML (in Friefox)

example-html-2

Example of rendered PDF (Linux in Evince)

Screenshot from 2022-09-22 11-26-04

@asgrim asgrim added the enhancement New feature or request label Sep 22, 2022
@asgrim asgrim added this to the 1.6.0 milestone Sep 22, 2022
@asgrim
Copy link
Member Author

asgrim commented Sep 22, 2022

Conlfuence writer regex needs updating actually (\Roave\DocbookTool\Writer\ConfluenceWriter::extractImagesFromContent is restricted to the generated diagrams currently)

Ocramius
Ocramius approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 then

As discussed with @asgrim, SVGs and such won't work yet, but that's fine for now.

@Ocramius Ocramius self-assigned this Sep 22, 2022
@Ocramius Ocramius merged commit 2bdd81e into 1.6.x Sep 22, 2022
@Ocramius
Copy link
Member

Aaaaaand I messed up -.-

#251 (comment)

Holding off a release.

@Ocramius Ocramius deleted the support-markdown-images branch September 22, 2022 10:53
@asgrim asgrim mentioned this pull request Sep 22, 2022
Open
@asgrim
Copy link
Member Author

asgrim commented Sep 22, 2022

As discussed with @asgrim, SVGs and such won't work yet, but that's fine for now.

SVG issue created in #252 for a future improvement 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Support embedding local images in generated PDFs
2 participants
@asgrim @Ocramius