Switch to PHPUnit 10 attributes instead of PHPDoc #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok guess, psalm can't deal with that. I'm not a psalm user and this is not important. Will close again silently :) looks like this is being tracked in psalm/psalm-plugin-phpunit#131 |
|
TBH, patch is valuable, but indeed needs upstream changes first. |
Ocramius
added
enhancement
|
Upstream patch is here: psalm/psalm-plugin-phpunit#145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing. Not sure in which direction you want to go, but since PHPDoc is deprecated with PHPUnit 11 and I'm adding attribute usage in my other PR, I thought it might be a good idea to keep this stuff consistent.