Develop (#62)

- fix #61 add Wire1 support for ESP32
RobTillaart · Sep 22, 2023 · 450fe8a · 450fe8a
1 parent b6e7592
commit 450fe8a
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 6 deletions.
diff --git a/ADS1X15.cpp b/ADS1X15.cpp
@@ -1,7 +1,7 @@
 //
 //    FILE: ADS1X15.cpp
 //  AUTHOR: Rob Tillaart
-// VERSION: 0.3.12
+// VERSION: 0.3.13
 //    DATE: 2013-03-24
 // PUPROSE: Arduino library for ADS1015 and ADS1115
 //     URL: https://github.com/RobTillaart/ADS1X15
@@ -144,7 +144,6 @@ void ADS1X15::reset()
 
 bool ADS1X15::begin(int sda, int scl)
 {
-  _wire = &Wire;
   _wire->begin(sda, scl);
   if ((_address < 0x48) || (_address > 0x4B)) return false;
   if (! isConnected()) return false;

diff --git a/ADS1X15.h b/ADS1X15.h
@@ -2,7 +2,7 @@
 //
 //    FILE: ADS1X15.h
 //  AUTHOR: Rob Tillaart
-// VERSION: 0.3.12
+// VERSION: 0.3.13
 //    DATE: 2013-03-24
 // PUPROSE: Arduino library for ADS1015 and ADS1115
 //     URL: https://github.com/RobTillaart/ADS1X15
@@ -12,7 +12,7 @@
 #include "Arduino.h"
 #include "Wire.h"
 
-#define ADS1X15_LIB_VERSION               (F("0.3.12"))
+#define ADS1X15_LIB_VERSION               (F("0.3.13"))
 
 //  allow compile time default address
 //  address in { 0x48, 0x49, 0x4A, 0x4B }, no test...

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## [0.3.13] - 2023-09-20
+- fix #61 ESP32 begin()
+
+
 ## [0.3.12] - 2023-09-11
 - update and add examples
 - add **getLastRequest()** to track last type of measurement.

diff --git a/README.md b/README.md
@@ -459,6 +459,10 @@ If, "Wire1" is used, you need to add "&Wire1" in the constructor.
 
 #### Should
 
+- investigate of remove the begin(sda, scl) versions 
+  as the responsibility for the Wire configuration 
+  should not be in this library. 
+
 
 #### Could
 

diff --git a/library.json b/library.json
@@ -15,7 +15,7 @@
     "type": "git",
     "url": "https://github.com/RobTillaart/ADS1X15"
   },
-  "version": "0.3.12",
+  "version": "0.3.13",
   "license": "MIT",
   "frameworks": "*",
   "platforms": "*",

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=ADS1X15
-version=0.3.12
+version=0.3.13
 author=Rob Tillaart <rob.tillaart@gmail.com>
 maintainer=Rob Tillaart <rob.tillaart@gmail.com>
 sentence=Arduino library for ADS1015 - I2C 12 bit ADC and ADS1115 I2C 16 bit ADC