Remove superfluous noop values #48
Conversation
For our own package, we need a name.
When trying to install dependencies, we run in to a yarn error "incorrect integrity when fetching from cache". After looking what might cause the error, i found this github thread: yarnpkg/yarn#7584 yarnpkg/yarn#7584 (comment) gives a temporary fix. Though it's clearly not that temporary, as a permanent fix is still not present in yarn v2.
Prior to this change several of the maps had multiple noop/none values. One "noop/none" value per map is more than sufficient. This change ensures all extra noop/none values are removed.
|
@RobertBroersma Not sure why there are multiple none versions for several of the possible attributes, but this ought to fix it. |
|
@Badlapje The extra noop values are there to prevent a disproportionate amount of facial hair and hats in randomly generated characters. I know it's not pretty, but it works :-) |
|
ah, if that's the idea, i can solve the visual without affecting the random generation, just a sec |
|
@RobertBroersma fixed it by adding a new object for the random generation, is this acceptable? |
|
@Badlapje Idk, it's kind of swapping out 1 bad hack for another slightly better hack. I guess this is fine, but I'll have to find some time to boot up this project, it's been a while. May I ask why you need this fix? |
|
I'm incorporating the bigheads as user avatars atm & i don't want to show several none values in the dropdown for facialHair and hats. I could just not use the hatMap and facialHairMap, but given that they are there it seems more logical to use them, in case some valid value changes down the road. You can see it on your own site: the dropdown is confusing for users atm
|
4 participants
Prior to this change several of the maps had multiple noop/none values. One "noop/none" value per map is more than sufficient.
This change ensures all extra noop/none values are removed.