feat: 405: Method not allowed #2366

RobinTail · 2025-01-31T22:30:46Z

There is an HTTP code 405 for routes that exist, but require different method.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405

Unfortunately, req.route is undefined when within middlewares, so have to use app.all() as recommended.

src/server.ts

src/server-helpers.ts

…ault.

src/server-helpers.ts

src/routing.ts

RobinTail

now ok

coveralls-official · 2025-02-03T10:10:37Z

coverage: 100.0%. remained the same
when pulling 12d3e9c on not-found-405
into 5fd6252 on master.

Feature was introduced in #2366 . Making it default behavior in next major.

Responding with 405: draft implementation.

cea730f

RobinTail added the enhancement New feature or request label Jan 31, 2025

RobinTail commented Jan 31, 2025

View reviewed changes

src/server.ts Outdated Show resolved Hide resolved

RobinTail added 12 commits January 31, 2025 23:56

Update src/server.ts

0d7710e

Accessing req.app conditionally.

41fb011

Using res.set instead of .setHeaders.

b56e88a

Updating protocol test.

0591abc

Test for 404 on invalid path.

aa55955

Ref: extracting findSupportedMethods().

bb66892

Separating suitable from matching.

fc02673

Using chain() instead of flatMap.

0c72a24

Ref: extracting types.

b431667

Ref: shortening with R.tryCatch().

4a6e0b4

Fix type name typo.

b9a9609

Experiment on tryCatch performance.

a6325e7

RobinTail commented Feb 1, 2025

View reviewed changes

src/server-helpers.ts Outdated Show resolved Hide resolved

RobinTail added 2 commits February 1, 2025 20:11

Making it configurable with preserving original behavior (404) by def…

6aea366

…ault.

Testing createNotFoundHandler for both cases.

f90371c

RobinTail marked this pull request as ready for review February 1, 2025 23:45

Minor: grammar.

2a38c46

RobinTail commented Feb 2, 2025

View reviewed changes

src/server-helpers.ts Outdated Show resolved Hide resolved

RobinTail marked this pull request as draft February 2, 2025 12:27

RobinTail added 2 commits February 2, 2025 21:45

REF: using proprietary routing for establishing 405 handler.

943d18c

rev experiment.

e51c95a

RobinTail commented Feb 2, 2025

View reviewed changes

src/routing.ts Outdated Show resolved Hide resolved

RobinTail commented Feb 2, 2025

View reviewed changes

src/routing.ts Outdated Show resolved Hide resolved

RobinTail added 4 commits February 2, 2025 22:31

Ref: rm return statement.

518dfa1

mv: createCatcher() helper.

44431b6

Test for routing.

a5a8e60

Extracting createWrongMethodHandler().

9254623

RobinTail added 2 commits February 3, 2025 07:13

rm redundant condition.

197e7a8

Testing createWrongMethodHandler().

e5760fe

RobinTail marked this pull request as ready for review February 3, 2025 06:21

RobinTail added 2 commits February 3, 2025 07:29

minor: todo.

fd5923f

Minor: prefixing unused argument.

e9743d0

RobinTail commented Feb 3, 2025

View reviewed changes

src/routing.ts Outdated Show resolved Hide resolved

RobinTail added 3 commits February 3, 2025 07:54

Fix: set Allowed header in the handler.

8a97e6a

Minor: comments and jsdoc.

74c1c66

Readme: listing the feature.

5f65931

RobinTail force-pushed the not-found-405 branch from 3a79747 to 5f65931 Compare February 3, 2025 09:47

Changelog: 22.5.0.

d2c2fc0

This comment was marked as outdated.

Sign in to view

RobinTail added the documentation Improvements or additions to documentation label Feb 3, 2025

RobinTail added 2 commits February 3, 2025 11:02

Merge branch 'master' into not-found-405

e900c26

FIX: Header name is Allow (not Allowed).

12d3e9c

RobinTail commented Feb 3, 2025

View reviewed changes

RobinTail merged commit cb506a1 into master Feb 3, 2025
9 checks passed

RobinTail deleted the not-found-405 branch February 3, 2025 10:10

RobinTail mentioned this pull request Feb 6, 2025

Change default response to 405 for wrong method #2372

Merged

RobinTail added a commit that referenced this pull request Feb 6, 2025

Change default response to 405 for wrong method (#2372)

b394427

Feature was introduced in #2366 . Making it default behavior in next major.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 405: Method not allowed #2366

feat: 405: Method not allowed #2366

RobinTail commented Jan 31, 2025 •

edited

Loading

This comment was marked as outdated.

RobinTail left a comment

coveralls-official bot commented Feb 3, 2025 •

edited

Loading

feat: 405: Method not allowed #2366

feat: 405: Method not allowed #2366

Conversation

RobinTail commented Jan 31, 2025 • edited Loading

This comment was marked as outdated.

RobinTail left a comment

Choose a reason for hiding this comment

coveralls-official bot commented Feb 3, 2025 • edited Loading

RobinTail commented Jan 31, 2025 •

edited

Loading

coveralls-official bot commented Feb 3, 2025 •

edited

Loading