Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package request ros2_control #102

Merged
merged 12 commits into from
Sep 14, 2023

Conversation

thinkabout4x
Copy link

No description provided.

@Tobias-Fischer
Copy link
Contributor

Hi @traversaro - do you happen to know a way around the vendored backward-cpp cmake issues? There is a backward.dll but not backward.lib, do we need to export all symbols? The best way would be to unvendor completely I guess, but for now I’d be happy with a workaround ..

@traversaro
Copy link
Member

Hi @traversaro - do you happen to know a way around the vendored backward-cpp cmake issues? There is a backward.dll but not backward.lib, do we need to export all symbols? The best way would be to unvendor completely I guess, but for now I’d be happy with a workaround ..

Apparently that repos uses a forked version of backward-cpp from 2017, see pal-robotics/backward_ros@c9251fd . Indeed, it seems that adding set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) before https://github.com/pal-robotics/backward_ros/blob/foxy-devel/CMakeLists.txt#L62 could fix the problem.

@Tobias-Fischer
Copy link
Contributor

Finally ;).

Thanks for your help @traversaro!

@Tobias-Fischer Tobias-Fischer merged commit 26c266b into RoboStack:main Sep 14, 2023
5 checks passed
@Tobias-Fischer Tobias-Fischer mentioned this pull request Sep 14, 2023
5 tasks
@thinkabout4x thinkabout4x deleted the ros2_control_request branch September 14, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants