Various Fixes for January Rebuild on Windows

.github/workflows/testpr.yml

@@ -1,7 +1,5 @@
 on:
-  pull_request:
-    paths:
-      - '*.yaml'
+  pull_request
 
 env:
   ROS_VERSION: 2

patch/ros-humble-control-toolbox.patch

@@ -0,0 +1,12 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 7d3a2c7..4d5745c 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -73,6 +73,7 @@ target_include_directories(low_pass_filter PUBLIC
+     $<INSTALL_INTERFACE:include/control_toolbox>
+ )
+ target_link_libraries(low_pass_filter PUBLIC low_pass_filter_parameters)
++set_target_properties(low_pass_filter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS TRUE)
+ ament_target_dependencies(low_pass_filter PUBLIC ${CONTROL_FILTERS_INCLUDE_DEPENDS})
+
+ # Install pluginlib xml

patch/ros-humble-hardware-interface.patch

@@ -0,0 +1,24 @@
+diff --git a/hardware_interface/include/hardware_interface/lexical_casts.hpp b/hardware_interface/include/hardware_interface/lexical_casts.hpp
+index 846d9f757c..042361e392 100644
+--- a/hardware_interface/include/hardware_interface/lexical_casts.hpp
++++ b/hardware_interface/include/hardware_interface/lexical_casts.hpp
+@@ -21,6 +21,8 @@
+ #include <stdexcept>
+ #include <string>
+
++#include "hardware_interface/visibility_control.h"
++
+ namespace hardware_interface
+ {
+
+@@ -29,8 +31,10 @@ namespace hardware_interface
+  * from
+  https://github.com/ros-planning/srdfdom/blob/ad17b8d25812f752c397a6011cec64aeff090c46/src/model.cpp#L53
+ */
++HARDWARE_INTERFACE_PUBLIC
+ double stod(const std::string & s);
+
++HARDWARE_INTERFACE_PUBLIC
+ bool parse_bool(const std::string & bool_string);
+
+ }  // namespace hardware_interface

patch/ros-humble-rsl.win.patch

@@ -0,0 +1,26 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 6d47b08..1b0c4f0 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -30,6 +37,21 @@ target_link_libraries(rsl PUBLIC
+     tl_expected::tl_expected
+ )
+
++# There is no explicit export of symbols in the library either via
++# hand-written ***_export.h headers or generate_export_header CMake macro,
++# as the header-only functions in this library are quite limited in number,
++# it is perfectly ok to export all of them (as done in *nix) with the
++# WINDOWS_EXPORT_ALL_SYMBOLS property
++if(MSVC)
++    set_target_properties(rsl PROPERTIES
++        WINDOWS_EXPORT_ALL_SYMBOLS TRUE
++    )
++    # On Windows, also ensure that all .dll libraries are placed in the
++    # same build directory so they can be found by the loader (there is
++    # no rpath on Windows)
++    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR}")
++endif()
++
+ add_subdirectory(docs)
+
+ option(RSL_BUILD_TESTING "Build tests" OFF)

patch/ros-humble-steering-controllers-library.patch

@@ -0,0 +1,24 @@
+diff --git a/steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp b/steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp
+index 095db7674b..88063ea4a2 100644
+--- a/steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp
++++ b/steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp
+@@ -16,6 +16,7 @@
+ #define STEERING_CONTROLLERS_LIBRARY__STEERING_CONTROLLERS_LIBRARY_HPP_
+
+ #include <chrono>
++#define _USE_MATH_DEFINES
+ #include <cmath>
+ #include <memory>
+ #include <queue>
+diff --git a/steering_controllers_library/src/steering_odometry.cpp b/steering_controllers_library/src/steering_odometry.cpp
+index 3e1b586807..dbbbf6f850 100644
+--- a/steering_controllers_library/src/steering_odometry.cpp
++++ b/steering_controllers_library/src/steering_odometry.cpp
+@@ -19,6 +19,7 @@
+
+ #include "steering_controllers_library/steering_odometry.hpp"
+
++#define _USE_MATH_DEFINES
+ #include <cmath>
+ #include <iostream>
+

patch/ros-humble-yaml-cpp-vendor.patch

@@ -0,0 +1,20 @@
+From 25757ddc5272ea80a099c4b8fb7c4c90708416e4 Mon Sep 17 00:00:00 2001
+From: Silvio Traversaro <silvio@traversaro.it>
+Date: Sat, 10 Feb 2024 16:14:21 +0100
+Subject: [PATCH] Support yaml-cpp >= 0.8.0
+
+Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
+---
+ yaml_cpp_vendor-extras.cmake.in | 17 +++++++++++------
+ 1 file changed, 11 insertions(+), 6 deletions(-)
+
+diff --git a/yaml_cpp_vendor-extras.cmake.in b/yaml_cpp_vendor-extras.cmake.in
+index deac98c..48eb4a9 100644
+--- a/yaml_cpp_vendor-extras.cmake.in
++++ b/yaml_cpp_vendor-extras.cmake.in
+@@ -15,4 +15,4 @@ endif()
+ set(yaml_cpp_vendor_LIBRARIES ${YAML_CPP_LIBRARIES})
+ set(yaml_cpp_vendor_INCLUDE_DIRS ${YAML_CPP_INCLUDE_DIR})
+
+-list(APPEND yaml_cpp_vendor_TARGETS yaml-cpp)
++list(APPEND yaml_cpp_vendor_TARGETS yaml-cpp::yaml-cpp)

vinca_win.yaml

@@ -63,3 +63,4 @@ packages_select_by_deps:
   # - moveit
 
 patch_dir: patch
+