Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rosbag2-storage-mcap on linux-64 and win-64 #202

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add rosbag2-storage-mcap on linux-64 and win-64 #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9237d4
Add rosbag2-storage-mcap on linux-64
Tobias-Fischer Aug 21, 2024
8a6dbda
Add rosbag2-storage-mcap on win
Tobias-Fischer Aug 21, 2024
50487ed
Update ros-humble-pid-controller.patch
Tobias-Fischer Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions patch/ros-humble-pid-controller.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/pid_controller/CMakeLists.txt b/pid_controller/CMakeLists.txt
index 15e903222a..6c9e00ef8b 100644
index 81cbe6f006..d7798b579b 100644
--- a/pid_controller/CMakeLists.txt
+++ b/pid_controller/CMakeLists.txt
@@ -45,7 +45,7 @@ ament_target_dependencies(pid_controller PUBLIC ${THIS_PACKAGE_INCLUDE_DEPENDS})
Expand All @@ -12,10 +12,10 @@ index 15e903222a..6c9e00ef8b 100644
pluginlib_export_plugin_description_file(controller_interface pid_controller.xml)

diff --git a/pid_controller/include/pid_controller/pid_controller.hpp b/pid_controller/include/pid_controller/pid_controller.hpp
index f7b8cc4491..788f39f1ed 100644
index 105a915442..4919a739ce 100644
--- a/pid_controller/include/pid_controller/pid_controller.hpp
+++ b/pid_controller/include/pid_controller/pid_controller.hpp
@@ -121,8 +121,10 @@ class PidController : public controller_interface::ChainableControllerInterface
@@ -119,8 +119,10 @@ class PidController : public controller_interface::ChainableControllerInterface
std::unique_ptr<ControllerStatePublisher> state_publisher_;

// override methods from ChainableControllerInterface
Expand Down
1 change: 1 addition & 0 deletions vinca_linux_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ packages_select_by_deps:

- gtsam
- motion-capture-tracking
- rosbag2-storage-mcap

# Needs fixing
# - moveit-resources
Expand Down
1 change: 1 addition & 0 deletions vinca_win.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ packages_select_by_deps:
- gazebo-ros2-control
- ros2-controllers-test-nodes
- joint-state-publisher-gui
- rosbag2-storage-mcap

# Broken for now until we migrate to newer gazebo
# - desktop_full
Expand Down
Loading