-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vision-msgs-rviz-plugins for linux-* and osx-* #90
Merged
Tobias-Fischer
merged 13 commits into
RoboStack:main
from
anand-bala:vision-msgs-rviz-plugins
Sep 17, 2023
Merged
Add vision-msgs-rviz-plugins for linux-* and osx-* #90
Tobias-Fischer
merged 13 commits into
RoboStack:main
from
anand-bala:vision-msgs-rviz-plugins
Sep 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @anand-bala - do you need Windows? It seems like something is wrong in a cmake somewhere, if you don't need it I'd suggest to merge the other platforms only. |
…msgs-rviz-plugins.patch
Tobias-Fischer
changed the title
Add vision-msgs-rviz-plugins for all platforms
Add vision-msgs-rviz-plugins for linux-* and osx-*
Sep 17, 2023
Let me know if you really need Win and I can take another look. For now merging for the other platforms. |
I think you can get rid of Windows. Not really an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83 (but is blocked by upstream issue mamba-org/boa#284)