-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIGNOR 3.0 parser. Updated to map SIGNOR phenotypes to GO terms when … #251
base: master
Are you sure you want to change the base?
Conversation
…available from their mappings.
Common/data_sources.py
Outdated
@@ -78,7 +79,8 @@ | |||
PLANT_GOA: ("parsers.GOA.src.loadGOA", "PlantGOALoader"), | |||
REACTOME: ("parsers.Reactome.src.loadReactome", "ReactomeLoader"), | |||
SCENT: ("parsers.scent.src.loadScent", "ScentLoader"), | |||
SGD: ("parsers.SGD.src.loadSGD", "SGDLoader"), | |||
SGD: ("parsers.SIGNOR.src.loadSIGNOR", "SIGNORLoader"), | |||
SIGNOR: ("parsers.SGD.src.loadSGD", "SGDLoader"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just lurking but noticed the constants might be reversed (signor values in sgd and the other way around)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad!! Thanks for catching this.
Sorry I don't know enough about your project to review, I am a colleague of @DnlRKorn from an entirely different KG land.. 😂 good luck with your work! |
Currently, it cannot be run as written.
Please add files and define variable |
self.data_path is actually set in the init of the SourceDataLoader interface, which all parsers inherit from, and should call with super().init so that is not an issue. Maybe not the easiest to read code design but that's how it works for all them. ORION/Common/loader_interface.py Lines 32 to 37 in b124dfb
|
Fixed issue where SIGNOR parsing fails due to filename not being included in self.data_files list.
Deleted one unnecessary line.
Updated to map SIGNOR phenotypes to GO terms when available from their mappings. A similar mapping process can be repeated for the complexes, protein families, and stimuli terms if SIGNOR ever updates their mappings.