Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGNOR 3.0 parser. Updated to map SIGNOR phenotypes to GO terms when … #251

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

beasleyjonm
Copy link
Contributor

Updated to map SIGNOR phenotypes to GO terms when available from their mappings. A similar mapping process can be repeated for the complexes, protein families, and stimuli terms if SIGNOR ever updates their mappings.

@@ -78,7 +79,8 @@
PLANT_GOA: ("parsers.GOA.src.loadGOA", "PlantGOALoader"),
REACTOME: ("parsers.Reactome.src.loadReactome", "ReactomeLoader"),
SCENT: ("parsers.scent.src.loadScent", "ScentLoader"),
SGD: ("parsers.SGD.src.loadSGD", "SGDLoader"),
SGD: ("parsers.SIGNOR.src.loadSIGNOR", "SIGNORLoader"),
SIGNOR: ("parsers.SGD.src.loadSGD", "SGDLoader"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just lurking but noticed the constants might be reversed (signor values in sgd and the other way around)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad!! Thanks for catching this.

@matentzn
Copy link

Sorry I don't know enough about your project to review, I am a colleague of @DnlRKorn from an entirely different KG land.. 😂 good luck with your work!

@eKathleenCarter
Copy link
Contributor

@beasleyjonm

Currently, it cannot be run as written.

  1. SIGNOR-ST.csv, SIGNOR-PH.csv files are not included.
  2. self.data_path not set.

Please add files and define variable

@EvanDietzMorris
Copy link
Contributor

self.data_path is actually set in the init of the SourceDataLoader interface, which all parsers inherit from, and should call with super().init so that is not an issue. Maybe not the easiest to read code design but that's how it works for all them.

if source_data_dir:
self.data_path = os.path.join(source_data_dir, "source")
if not os.path.exists(self.data_path):
os.mkdir(self.data_path)
else:
self.data_path = os.environ.get("ORION_STORAGE")

Fixed issue where SIGNOR parsing fails due to filename not being included in self.data_files list.
Deleted one unnecessary line.
@eKathleenCarter eKathleenCarter linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGNOR
5 participants