Skip to content

Commit

Permalink
Finish reenabling action capabilities tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sea-bass committed Dec 18, 2024
1 parent 1f870c0 commit e971732
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import rclpy
from action_msgs.msg import GoalStatus
from example_interfaces.action._fibonacci import Fibonacci_FeedbackMessage
from rclpy.executors import SingleThreadedExecutor
from rclpy.executors import MultiThreadedExecutor
from rclpy.node import Node
from rclpy.qos import DurabilityPolicy, QoSProfile, ReliabilityPolicy
from rosbridge_library.capabilities.action_feedback import ActionFeedback
Expand All @@ -25,7 +25,7 @@
class TestActionCapabilities(unittest.TestCase):
def setUp(self):
rclpy.init()
self.executor = SingleThreadedExecutor()
self.executor = MultiThreadedExecutor()
self.node = Node("test_action_capabilities")
self.executor.add_node(self.node)

Expand Down Expand Up @@ -295,7 +295,6 @@ def test_cancel_advertised_action(self):
self.assertEqual(self.received_message["values"]["sequence"], [])
self.assertEqual(self.received_message["status"], GoalStatus.STATUS_CANCELED)

@unittest.skip("Currently raises an exception not catchable by unittest, need to fix this")
def test_unadvertise_action(self):
# Advertise the action
action_path = "/fibonacci_action_4"
Expand Down Expand Up @@ -340,8 +339,6 @@ def test_unadvertise_action(self):
self.assertTrue("id" in self.received_message)

# Now unadvertise the action
# TODO: This raises an exception, likely because of the following rclpy issue:
# https://github.com/ros2/rclpy/issues/1098
unadvertise_msg = loads(dumps({"op": "unadvertise_action", "action": action_path}))
self.received_message = None
self.unadvertise.unadvertise_action(unadvertise_msg)
Expand Down

0 comments on commit e971732

Please sign in to comment.