Skip to content

Handle rosapi param responses #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Handle rosapi param responses #930

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cae3f8
Handle rosapi param responses
bjsowa Aug 29, 2025
67b8794
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 4, 2025
9af1fe1
Simplify checking result, call normal callback when failedCallback no…
bjsowa Sep 9, 2025
de31a7f
Update failedCallback description
bjsowa Sep 9, 2025
0e078ff
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 15, 2025
c2d4a2b
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions src/core/Param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default class Param {
* Fetch the value of the param.
*
* @param {getCallback} callback - The callback function.
* @param {getFailedCallback} [failedCallback] - The callback function when the service call failed.
* @param {getFailedCallback} [failedCallback] - The callback function when the service call failed or the parameter retrieval was unsuccessful.
*/
get(callback, failedCallback) {
var paramClient = new Service({
Expand All @@ -40,13 +40,17 @@ export default class Param {
serviceType: 'rosapi/GetParam'
});

var request = {name: this.name};
var request = { name: this.name };

paramClient.callService(
request,
function (result) {
var value = JSON.parse(result.value);
callback(value);
if (result.successful === false && failedCallback) {
failedCallback(result.reason);
} else {
var value = JSON.parse(result.value);
callback(value);
}
},
failedCallback
);
Expand All @@ -64,7 +68,7 @@ export default class Param {
*
* @param {Object} value - The value to set param to.
* @param {setParamCallback} [callback] - The callback function.
* @param {setParamFailedCallback} [failedCallback] - The callback function when the service call failed.
* @param {setParamFailedCallback} [failedCallback] - The callback function when the service call failed or the parameter setting was unsuccessful.
*/
set(value, callback, failedCallback) {
var paramClient = new Service({
Expand All @@ -78,13 +82,23 @@ export default class Param {
value: JSON.stringify(value)
};

paramClient.callService(request, callback, failedCallback);
paramClient.callService(
request,
function (result) {
if (result.successful === false && failedCallback) {
failedCallback(result.reason);
} else if (callback) {
callback(result);
}
},
failedCallback
);
}
/**
* Delete this parameter on the ROS server.
*
* @param {setParamCallback} callback - The callback function.
* @param {setParamFailedCallback} [failedCallback] - The callback function when the service call failed.
* @param {setParamFailedCallback} [failedCallback] - The callback function when the service call failed or the parameter deletion was unsuccessful.
*/
delete(callback, failedCallback) {
var paramClient = new Service({
Expand All @@ -97,6 +111,16 @@ export default class Param {
name: this.name
};

paramClient.callService(request, callback, failedCallback);
paramClient.callService(
request,
function (result) {
if (result.successful === false && failedCallback) {
failedCallback(result.reason);
} else if (callback) {
callback(result);
}
},
failedCallback
);
}
}