Rjd 1278/fix line segment #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests to LidarSensor - Addede unit tests to Primitive - Refactored Raycaster unit tests
- Added missed header file
- Removed dummy class - Updated unit tests
…m:tier4/scenario_simulator_v2 into RJD-1278/fix-line-segment
dmoszynski
reviewed
Aug 21, 2024
dmoszynski
reviewed
Aug 21, 2024
dmoszynski
reviewed
Aug 22, 2024
dmoszynski
reviewed
Aug 22, 2024
dmoszynski
reviewed
Aug 22, 2024
dmoszynski
reviewed
Aug 22, 2024
dmoszynski
reviewed
Aug 22, 2024
dmoszynski
reviewed
Aug 23, 2024
| /// The term "2D" in the function name specifically refers to the intersection point, not the SValue. | ||
| /// Therefore, the intersection is determined by disregarding the z-coordinate, hence the term "2D." | ||
| /// After finding the intersection, we calculate its position using a proportion. | ||
| /// Finally, we multiply this proportion by the actual 3D length to obtain the total SValue. |
…nit_tests_lidar Test: [RJD-937] to Implement Unit tests on simple_sensor_simulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR contains combined fixes for issues tier4#1343 and tier4#1344.
Details
Additionally:
LineSegmentclass, namelylength,length_2d,vectorandvector_2d. These constants are frequently used and can be easily calculated during construction.getIntersection2DSValuehas been renamed toget2DIntersectionSValue. In my opinion, in previous version it was unclear if2Drefers toIntersectionorSValue.isIntersect2DandgetIntersection2Dhad a duplicate. This was simplified.getSlopehas been renamed toget2DVectorSlope, now it throws an error if division by 0 occurs.Background
Please see tier4#1343 and tier4#1344 for detailed explanations of the bugs.