Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 17, 2025

The elevator_action_plugin uses actionlib::SimpleActionClient at runtime, but package.xml only declared actionlib as a build dependency.

Changes

  • Added <exec_depend>actionlib</exec_depend> to robotnik_pad_plugins/package.xml following the pattern of other runtime dependencies (roscpp, pluginlib, etc.)
<build_depend>actionlib</build_depend>

<exec_depend>roscpp</exec_depend>
<exec_depend>pluginlib</exec_depend>
<exec_depend>robotnik_pad</exec_depend>
<exec_depend>robotnik_pad_msgs</exec_depend>
<exec_depend>actionlib</exec_depend>  <!-- Added -->

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits December 17, 2025 12:08
Co-authored-by: jamendezib <126663352+jamendezib@users.noreply.github.com>
Co-authored-by: jamendezib <126663352+jamendezib@users.noreply.github.com>
Co-authored-by: jamendezib <126663352+jamendezib@users.noreply.github.com>
@jamendezib jamendezib marked this pull request as ready for review December 17, 2025 12:10
Copilot AI changed the title [WIP] WIP Address feedback on elevator_action_plugin implementation Add missing actionlib exec_depend to package.xml Dec 17, 2025
@jamendezib jamendezib merged commit 9d465b5 into feat/noetic/elevator-action-plugin Dec 17, 2025
Copilot AI requested a review from jamendezib December 17, 2025 12:10
@jamendezib jamendezib deleted the copilot/sub-pr-31 branch December 17, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants