Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Workflow #82

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Update GH Workflow #82

merged 5 commits into from
Nov 19, 2024

Conversation

ioduok
Copy link
Contributor

@ioduok ioduok commented Nov 12, 2024

No description provided.

@ioduok ioduok requested review from helrond and HaSistrunk November 12, 2024 21:20
Copy link
Member

@HaSistrunk HaSistrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're replacing Travis with the new Github Actions workflows, you'll also want to delete the .travis.yml file and the [![Build Status](https://travis-ci.org... bit that references the Travis build in the README.md file.

@ioduok ioduok requested a review from HaSistrunk November 13, 2024 14:22
Copy link
Member

@helrond helrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to merge as-is, but I'm noting that there's no deploy workflow (which there wasn't in the Travis configs either). @p-galligan can you put adding that workflow on your to-do list? This should deploy to PyPI, probably when we cut a release (or whatever our general pattern is for deploying to PyPI).

updating python@v4 to python@v5

Co-authored-by: Hannah Sistrunk <hsistrunk@rockarch.org>
@ioduok ioduok requested a review from HaSistrunk November 15, 2024 19:07
@p-galligan
Copy link
Member

I think this is okay to merge as-is, but I'm noting that there's no deploy workflow (which there wasn't in the Travis configs either). @p-galligan can you put adding that workflow on your to-do list? This should deploy to PyPI, probably when we cut a release (or whatever our general pattern is for deploying to PyPI).

Following up here as well that I a python publish workflow already exists for this repo.

@ioduok ioduok requested a review from p-galligan November 19, 2024 20:20
@ioduok ioduok merged commit 834f1cb into development Nov 19, 2024
2 checks passed
@ioduok ioduok deleted the workflow-updates branch November 19, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants