Fix translated chat text links losing URL entities#11
Merged
Rocket-Space merged 1 commit intomasterfrom Feb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
text_link/URL entities to be lost because the original token-based masking did not survive reordering by the translator.Description
TranslationHelper.maskLinksto emit tagged placeholders that include an ID and the original visible text using the format[[ENT_START_n]]...[[ENT_END_n]]instead of a plain token. (TMessagesProj/src/main/java/org/spacegram/translator/TranslationHelper.java).idfield toLinkPlaceholderand store originalurlandtextUrlflags to map translated fragments back to their original entities. (LinkPlaceholder).restoreTaggedEntities(...)which parses the[[ENT_START_n]]...[[ENT_END_n]]blocks from translated output, inserts the translated visible text into the result, and reconstructsTL_messageEntityTextUrl/TL_messageEntityUrlentities with correct offsets and original URLs. (restoreTaggedEntities+ fallback to legacy restoration).Testing
./gradlew :TMessagesProj:compileDebugJavaWithJavac -x lint, but the build failed due to the local Java/Gradle environment mismatch (Unsupported class file major version 69), so no successful compilation artifacts were produced on the runner.Codex Task