Respect inline translate style for single-message Translate and preserve link entities#12
Merged
Rocket-Space merged 1 commit intomasterfrom Feb 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On Message, causing unexpected UI behavior.Description
TranslationHelperand a new helper methodtryTranslateMessageInline(MessageObject, String)inChatActivitythat invokesTranslationHelper.translateMessage(...)whenSpaceGramConfig.translateStyle == 0and a non-Telegram provider is selected.ChatActivityto calltryTranslateMessageInline(...)first and only fall back toTranslateAlert2.showAlert(...)when inline translation is not applicable.MessageEntitylinks when translating on-message.TMessagesProj/src/main/java/org/telegram/ui/ChatActivity.java.Testing
./gradlew -q :TMessagesProj:compileDebugJavaWithJavac, but the local environment failed with a JDK/Gradle mismatch error (Unsupported class file major version 69), so a successful build could not be validated locally.rg/sed) to verify the new callsites and the presence of the new helper method; no runtime tests were executed due to the environment compile failure.Codex Task