Fix instant crash when using message translation option#13
Merged
Rocket-Space merged 1 commit intomasterfrom Feb 25, 2026
Merged
Fix instant crash when using message translation option#13Rocket-Space merged 1 commit intomasterfrom
Rocket-Space merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NotificationCenter.messageTranslated, which produced aClassCastException: java.lang.Long cannot be cast to org.telegram.messenger.MessageObjectinChatActivity.didReceivedNotification.ChatActivityexpects the firstmessageTranslatedargument to be aMessageObject(with optional booleans after it), while the translator was sendingdialogIdandmessageId(Longs).Description
TranslationHelperto postNotificationCenter.messageTranslatedwith theMessageObjectand the two boolean flags instead of(dialogId, messageId)for the inline translation completion path inTMessagesProj/src/main/java/org/spacegram/translator/TranslationHelper.java.TranslationHelper.clearTranslation(...)so both code paths follow the contract expected byChatActivity.TMessagesProj/src/main/java/org/spacegram/translator/TranslationHelper.javaand has been committed.Testing
./gradlew :TMessagesProj:compileDebugJavaWithJavac -x lint, but the build could not run in this environment due to a Gradle/JDK incompatibility (Unsupported class file major version 69), so automated compilation did not complete successfully.Codex Task