Avoid stuck dimming when translating a single message#14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27eb0c26dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true; | ||
| // Force the per-message action to use the same translation UI flow as full chat | ||
| // translation, which correctly handles chat dimming lifecycle. | ||
| return false; |
There was a problem hiding this comment.
Preserve inline translation for "On Message" style
This unconditional return false removes the only inline path for per-message translation, so when SpaceGramConfig.translateProvider != 0 and users select the "On Message" translation style, the context action now always falls back to TranslateAlert2 popup flow. That is a behavior regression for a user-configurable feature (style setting is still exposed in SpaceGram settings), not just a dimming lifecycle change.
Useful? React with 👍 / 👎.
Motivation
Description
tryTranslateMessageInlineinChatActivityto always returnfalse, removing the inline shortcut so callers fall back to the existingTranslateAlert2flow that properly handles dim/undim lifecycle; removed the unusedTranslationHelperimport.Testing
./gradlew :TMessagesProj:compileDebugJavaWithJavac -x lint, which failed due to the environment JDK/Gradle incompatibility (Unsupported class file major version 69).git status --shortandgit show --stat --oneline HEAD.Codex Task