Allow owners to delegate no-forward bypass to specific admins#16
Merged
Rocket-Space merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
noforwardsto specific admins.Description
userIdand adding user-scoped helpers inMessagesController:isNoForwardsAdminBypassEnabled(chatId, userId),setNoForwardsAdminBypassEnabled(chatId, userId, enabled)andcanBypassNoForwards(chatId); also addedgetNoForwardsAdminsBypassKey(chatId, userId)and adjusted checks to use current user id.ChatActivitysonoforwardsmessages can be forwarded when the currently signed-in user has bypass rights by addingcanBypassMessageNoForwards(...)and using it when computingcanForwardMessageandhasSelectedNoforwardsMessage().ChatEditTypeActivity) to avoid exposing a chat-global bypass switch there.ChatRightsEditActivity) which is shown when the chat hasnoforwardsand the editor is the chat owner, and persist that per-admin setting when admin rights are saved.MessagesController.java,ChatActivity.java,ChatEditTypeActivity.java,ChatRightsEditActivity.java(UI and logic updates described above).Testing
./gradlew :TMessagesProj:compileDebugJavaWithJavac -x lintto validate Java changes, but the build failed in this environment with a JDK/Gradle compatibility error:Unsupported class file major version 69(environment limitation, not related to source changes).Codex Task