Preserve hyperlink entities during alternative translations#17
Merged
Rocket-Space merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MessageEntityobjects remain clickable and correctly positioned when using alternative translation providers that return plain text.Description
alternativeTranslateWithEntitiesinTranslateAlert2which masks link entities with placeholders, calls the alternative translator, and restores both visible text andMessageEntityinstances into the translated result usingpreprocess.PlaceholderLink,isLinkEntity, andcloneLinkEntityto manage masking and recreation of link entities in the target text.translateAlt()inTranslateAlert2to use the new entity-preserving flow and to build aSpannableviaMessageObject.addEntitiesToText(...)so links remain interactive in the UI.TranslateControllerbatching/fallback paths to callTranslateAlert2.alternativeTranslateWithEntities(...)for provider-based translations and removed an unused import (SpaceGramTranslator) fromTranslateController.Testing
./gradlew -q :TMessagesProj:compileDebugJavaWithJavac, but it failed due to an environment JDK/Gradle mismatch (Unsupported class file major version 69), so full compile-time verification could not be completed here.gitcommit completed) and created the PR; no unit/integration tests were run in this environment due to the build failure.Codex Task