Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding issue contextual bar #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

henit-chobisa
Copy link
Contributor

Closes #94

Issue(s)

We have a button in UserProfileView, which tends to open user's issues, with it's states of mentioned / created and open / close, but the supporting SurfaceView that lists the issues is a ModalView which is not the best solution to display list like data, hence I request to switch to Contextual Bar View, which doesn't block user's activity while working on any chat and keeps the issues handy in contextual bar.

Acceptance Criteria fulfillment

  • Replace UserIssuesModal with UserIssuesContextualBar under a new Directory with Contextual Bars.
  • Update ContextualBar Actions that updated the Current Modal to updating the current contextual bar.

Proposed changes (including videos or screenshots)

IssueListContextualBar

Copy link
Collaborator

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henit-chobisa Why does this completely remove userIssuesModal and if it does, did we check for backward compatibility incase the modal was being used elsewhere ?

@henit-chobisa
Copy link
Contributor Author

@henit-chobisa Why does this completely remove userIssuesModal and if it does, did we check for backward compatibility incase the modal was being used elsewhere ?

@samad-yar-khan, I have checked all the places where the userIssuesModal is used and modified it to the contextual bar.
So far, I am sure that the userIssuesModal has not been used anywhere except the profile view, If you say, I can still keep a copy of userIssuesModal for backward compatibility ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displaying Issues in Contextual Bar Provided Better UX than Modal View
2 participants