chore: remove detox #6704

Rohit3523 · 2025-10-03T16:24:30Z

Proposed changes

Since we have migrated to Maestro for E2E testing, this PR removes Detox, its related tests and Detox native code from Android.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Tests
- Removed the entire end-to-end testing suite and Detox setup across platforms.
- Eliminated related test configurations and utilities.
Documentation
- Removed E2E testing guidance from contributor documentation.
- Deleted the dedicated E2E testing README.
Chores
- Cleaned up build settings by removing unused test-related configurations.
- Removed Detox-related dependencies and scripts from project tooling.

coderabbitai · 2025-10-03T16:24:42Z

Walkthrough

This PR removes the Detox end-to-end testing stack and all associated assets: configurations, Android integration, test helpers, TypeScript config, documentation, and all Detox test suites. It also deletes related npm scripts and dependencies and drops Detox repositories from Android Gradle config.

Changes

Cohort / File(s)	Summary of changes
Detox config removal `\.detoxrc.js`	Deleted Detox configuration export.
Documentation updates `CONTRIBUTING.md`, `e2e/README.md`	Removed E2E/Detox references and entire E2E README.
Android Detox integration `android/app/build.gradle`, `android/build.gradle`, `android/app/src/androidTest/.../DetoxTest.java`	Removed Detox repos, instrumentation test config, Detox dependency, appcompat dependency, and Detox instrumentation test.
E2E helpers and configs `e2e/helpers/*`, `e2e/jest.config.js`, `e2e/testSequencer.js`, `e2e/tsconfig.json`, `e2e/data.ts`, `e2e/e2e_account.example.ts`	Deleted all Detox helpers, API/data setup utilities, Jest config/sequencer, TS config, and example account/data modules.
Assorted Detox tests `e2e/tests/assorted/*`	Deleted all assorted Detox test suites (encryption, broadcast, profile, settings, status, server changes, notifications, i18n, display prefs, accessibility, preferences, etc.).
Onboarding Detox tests `e2e/tests/onboarding/*`	Deleted all onboarding Detox test suites (onboarding, legal, forgot password, create user, login, rooms list, server history, forced password change).
Room Detox tests `e2e/tests/room/*`	Deleted all room-related Detox test suites (create room, room interactions, room actions, discussions, threads, group DM, mark as unread, room info, jump to message, ignore/report user, share message, auto-translate).
Team Detox tests `e2e/tests/team/*`	Deleted all team-related Detox test suites (create team, team interactions, move/convert).
NPM scripts and deps `package.json`	Removed e2e:* scripts and Detox devDependency.

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

text: migrated room test from detox to maestro #6598 — Introduces Maestro-based room E2E tests, indicating migration away from Detox.

Suggested reviewers

diegolmello

Poem

A hop, a skip—Detox takes flight,
My tests now rest in moonlit night.
I twitch my ears, new paths to chart,
With Maestro maps and bunny heart.
Goodbye old trails, so neat, so keen—
Hello to greener testing green! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly states the primary change by indicating the removal of Detox in a chore commit, making it clear and specific without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch remove-detox-e2e

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between aa94a59 and e6ac749.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (55)

.detoxrc.js (0 hunks)
CONTRIBUTING.md (0 hunks)
android/app/build.gradle (0 hunks)
android/app/src/androidTest/java/chat/rocket/reactnative/DetoxTest.java (0 hunks)
android/build.gradle (0 hunks)
e2e/README.md (0 hunks)
e2e/data.ts (0 hunks)
e2e/e2e_account.example.ts (0 hunks)
e2e/helpers/app.ts (0 hunks)
e2e/helpers/data_setup.ts (0 hunks)
e2e/helpers/random.ts (0 hunks)
e2e/jest.config.js (0 hunks)
e2e/testSequencer.js (0 hunks)
e2e/tests/assorted/01-e2eencryption.spec.ts (0 hunks)
e2e/tests/assorted/02-broadcast.spec.ts (0 hunks)
e2e/tests/assorted/03-profile.spec.ts (0 hunks)
e2e/tests/assorted/04-setting.spec.ts (0 hunks)
e2e/tests/assorted/05-joinpublicroom.spec.ts (0 hunks)
e2e/tests/assorted/06-status.spec.ts (0 hunks)
e2e/tests/assorted/07-changeserver.spec.ts (0 hunks)
e2e/tests/assorted/08-joinprotectedroom.spec.ts (0 hunks)
e2e/tests/assorted/09-joinfromdirectory.spec.ts (0 hunks)
e2e/tests/assorted/10-deleteserver.spec.ts (0 hunks)
e2e/tests/assorted/11-deeplinking.spec.ts (0 hunks)
e2e/tests/assorted/12-i18n.spec.ts (0 hunks)
e2e/tests/assorted/13-display-pref.spec.ts (0 hunks)
e2e/tests/assorted/14-in-app-notification.spec.ts (0 hunks)
e2e/tests/assorted/15-change-avatar.spec.ts (0 hunks)
e2e/tests/assorted/16-accessibilityandappearance.spec.ts (0 hunks)
e2e/tests/assorted/17-userpreferences.spec.ts (0 hunks)
e2e/tests/onboarding/01-onboarding.spec.ts (0 hunks)
e2e/tests/onboarding/02-legal.spec.ts (0 hunks)
e2e/tests/onboarding/03-forgotpassword.spec.ts (0 hunks)
e2e/tests/onboarding/04-createuser.spec.ts (0 hunks)
e2e/tests/onboarding/05-login.spec.ts (0 hunks)
e2e/tests/onboarding/06-roomslist.spec.ts (0 hunks)
e2e/tests/onboarding/07-server-history.spec.ts (0 hunks)
e2e/tests/onboarding/08-change-password-required.spec.ts (0 hunks)
e2e/tests/room/01-createroom.spec.ts (0 hunks)
e2e/tests/room/02-room.spec.ts (0 hunks)
e2e/tests/room/03-roomactions.spec.ts (0 hunks)
e2e/tests/room/04-discussion.spec.ts (0 hunks)
e2e/tests/room/05-threads.spec.ts (0 hunks)
e2e/tests/room/06-createdmgroup.spec.ts (0 hunks)
e2e/tests/room/07-markasunread.spec.ts (0 hunks)
e2e/tests/room/08-roominfo.spec.ts (0 hunks)
e2e/tests/room/09-jumptomessage.spec.ts (0 hunks)
e2e/tests/room/10-ignoreuser.spec.ts (0 hunks)
e2e/tests/room/11-sharemessage.spec.ts (0 hunks)
e2e/tests/room/12-autotranslate.spec.ts (0 hunks)
e2e/tests/team/01-createteam.spec.ts (0 hunks)
e2e/tests/team/02-team.spec.ts (0 hunks)
e2e/tests/team/03-moveconvert.spec.ts (0 hunks)
e2e/tsconfig.json (0 hunks)
package.json (0 hunks)

💤 Files with no reviewable changes (55)

e2e/tests/room/06-createdmgroup.spec.ts
e2e/tests/room/07-markasunread.spec.ts
e2e/tests/assorted/11-deeplinking.spec.ts
e2e/tests/team/02-team.spec.ts
e2e/README.md
e2e/e2e_account.example.ts
e2e/tests/room/10-ignoreuser.spec.ts
e2e/tests/room/08-roominfo.spec.ts
e2e/tests/team/03-moveconvert.spec.ts
CONTRIBUTING.md
e2e/tests/onboarding/06-roomslist.spec.ts
e2e/helpers/app.ts
e2e/tests/assorted/03-profile.spec.ts
.detoxrc.js
e2e/tests/assorted/02-broadcast.spec.ts
e2e/tests/room/02-room.spec.ts
android/app/build.gradle
e2e/tests/assorted/08-joinprotectedroom.spec.ts
e2e/tsconfig.json
e2e/tests/onboarding/04-createuser.spec.ts
e2e/tests/room/09-jumptomessage.spec.ts
e2e/tests/onboarding/03-forgotpassword.spec.ts
e2e/helpers/random.ts
e2e/tests/room/03-roomactions.spec.ts
e2e/testSequencer.js
e2e/tests/assorted/13-display-pref.spec.ts
e2e/tests/room/04-discussion.spec.ts
package.json
e2e/jest.config.js
e2e/tests/team/01-createteam.spec.ts
e2e/tests/onboarding/05-login.spec.ts
e2e/tests/onboarding/08-change-password-required.spec.ts
e2e/tests/assorted/17-userpreferences.spec.ts
e2e/tests/assorted/10-deleteserver.spec.ts
e2e/tests/room/01-createroom.spec.ts
e2e/helpers/data_setup.ts
e2e/tests/assorted/05-joinpublicroom.spec.ts
e2e/tests/assorted/07-changeserver.spec.ts
e2e/tests/onboarding/01-onboarding.spec.ts
android/build.gradle
e2e/tests/assorted/15-change-avatar.spec.ts
e2e/tests/onboarding/02-legal.spec.ts
e2e/tests/room/11-sharemessage.spec.ts
android/app/src/androidTest/java/chat/rocket/reactnative/DetoxTest.java
e2e/data.ts
e2e/tests/room/12-autotranslate.spec.ts
e2e/tests/assorted/06-status.spec.ts
e2e/tests/assorted/04-setting.spec.ts
e2e/tests/room/05-threads.spec.ts
e2e/tests/assorted/01-e2eencryption.spec.ts
e2e/tests/assorted/14-in-app-notification.spec.ts
e2e/tests/assorted/12-i18n.spec.ts
e2e/tests/assorted/16-accessibilityandappearance.spec.ts
e2e/tests/assorted/09-joinfromdirectory.spec.ts
e2e/tests/onboarding/07-server-history.spec.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: E2E Run iOS / ios-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…eactNative into remove-detox-e2e

Remove detox test

e77969e

Rohit3523 had a problem deploying to approve_e2e_testing October 3, 2025 16:24 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_android_build October 3, 2025 16:28 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build October 3, 2025 16:28 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build October 3, 2025 16:28 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build October 3, 2025 16:28 — with GitHub Actions Error

Merge branch 'develop' into remove-detox-e2e

3da7fe1

Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 14:20 — with GitHub Actions Inactive

Rohit3523 had a problem deploying to experimental_ios_build October 15, 2025 14:25 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_android_build October 15, 2025 14:25 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build October 15, 2025 14:25 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build October 15, 2025 14:25 — with GitHub Actions Error

Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 16:00 — with GitHub Actions Inactive

Rohit3523 had a problem deploying to official_android_build October 15, 2025 16:03 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build October 15, 2025 16:03 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build October 15, 2025 16:03 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build October 15, 2025 16:03 — with GitHub Actions Error

Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…

e6ac749

…eactNative into remove-detox-e2e

Rohit3523 changed the title ~~Remove detox test~~ chore: remove detox Oct 15, 2025

Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 17:48 — with GitHub Actions Inactive

Rohit3523 requested a deployment to official_android_build October 15, 2025 17:52 — with GitHub Actions Waiting

Rohit3523 requested a deployment to experimental_ios_build October 15, 2025 17:52 — with GitHub Actions Waiting

Rohit3523 requested a deployment to experimental_android_build October 15, 2025 17:52 — with GitHub Actions Waiting

Rohit3523 requested a deployment to official_ios_build October 15, 2025 17:52 — with GitHub Actions Waiting

Rohit3523 marked this pull request as ready for review October 15, 2025 19:31

Rohit3523 requested a review from diegolmello October 15, 2025 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove detox #6704

chore: remove detox #6704

Uh oh!

Rohit3523 commented Oct 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore: remove detox #6704

Are you sure you want to change the base?

chore: remove detox #6704

Uh oh!

Conversation

Rohit3523 commented Oct 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Rohit3523 commented Oct 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 3, 2025 •

edited

Loading