-
Couldn't load subscription status.
- Fork 1.4k
fix: custom emoji align vertically in message #6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…tChat/Rocket.Chat.ReactNative into align-custom-emoji-in-chat
WalkthroughEmoji rendering was changed to wrap Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
app/containers/markdown/components/emoji/Emoji.tsx(2 hunks)
🧰 Additional context used
🪛 ESLint
app/containers/markdown/components/emoji/Emoji.tsx
[error] 3-3: All imports in the declaration are only used as types. Use import type.
(@typescript-eslint/consistent-type-imports)
🪛 GitHub Check: ESLint and Test / run-eslint-and-test
app/containers/markdown/components/emoji/Emoji.tsx
[failure] 3-3:
All imports in the declaration are only used as types. Use import type
Proposed changes
Right now custom emojis are not vertically center aligned in the chat which make the UI look bad. After some research i found that we can't vertically align image inside text and only way to make is center is applying translateY to the image
I can confirm that sending single emoji will not have different behaviour
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit