fix: files with non-latin characters fails to open#7054
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Android Build Available Rocket.Chat Experimental 4.71.0.108371 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTz597vp7ZL9uyIhl59w68W-4gwOvuolfHlCLcGNNkGir7ete3cVqHW0M28KjHvHlEz_WrYMuexmGismb6_ |
a1667e3 to
21be7fe
Compare
|
iOS Build Available Rocket.Chat Experimental 4.71.0.108373 |
|
Android Build Available Rocket.Chat Experimental 4.71.0.108385 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQctndjmU18ccwsvRLTlJD77sIfPZFoWRqJ7H-dn4AU64VPK5aXx4iFBkY082A_zdtO06D1bOS2L06fdV9c |
|
Android Build Available Rocket.Chat Experimental 4.71.0.108389 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNR-JuIF2NRVriX_fIz0YEzyjQ1fd_JfSi1HYV6k-Mdg9hyXjLcVXpXvF9eL3LxL3acx-CWf8NxvlbtYW93z |
|
iOS Build Available Rocket.Chat Experimental 4.71.0.108394 |
|
Android Build Available Rocket.Chat Experimental 4.71.0.108393 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSTvHtiYZr4MmN5qc3Hw0Qsvs1qfVXCSdroM_idorVvSAwjupIyxNXiHhKN-3ohKi86yvBjsu8u8MlCV2g8 |
OtavioStasiak
left a comment
There was a problem hiding this comment.
Tested and approved!
Proposed changes
Files shared in E2E channels with non-ASCII filenames (like 測試123.txt or Cyrillic characters) were failing to open on both Android and iOS.
This was happening because filenames were not properly decoded during decryption, so URL-encoded values were used instead of the actual names.
Issue(s)
http://rocketchat.atlassian.net/browse/SUP-1007
RocketChat/rocket.chat-mobile-crypto#13
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit