Skip to content

fix: files with non-latin characters fails to open#7054

Merged
Rohit3523 merged 8 commits intodevelopfrom
file-name-encoding
Mar 19, 2026
Merged

fix: files with non-latin characters fails to open#7054
Rohit3523 merged 8 commits intodevelopfrom
file-name-encoding

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Mar 16, 2026

Proposed changes

Files shared in E2E channels with non-ASCII filenames (like 測試123.txt or Cyrillic characters) were failing to open on both Android and iOS.

This was happening because filenames were not properly decoded during decryption, so URL-encoded values were used instead of the actual names.

Issue(s)

http://rocketchat.atlassian.net/browse/SUP-1007
RocketChat/rocket.chat-mobile-crypto#13

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Pinned a third-party dependency to a specific commit to improve stability and reproducibility of builds.
  • Style
    • Made non-functional formatting adjustments to TypeScript configuration comments and spacing; no behavioral or compilation changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The @rocket.chat/mobile-crypto dependency in package.json was pinned to a specific commit hash (RocketChat/rocket.chat-mobile-crypto#159d5f3e984345751bf4be196409604448be7131). tsconfig.json received formatting-only comment/spacing adjustments; no functional changes.

Changes

Cohort / File(s) Summary
Dependency Pin
package.json
Updated @rocket.chat/mobile-crypto dependency specifier to a specific commit hash (RocketChat/rocket.chat-mobile-crypto#159d5f3e984345751bf4be196409604448be7131).
TSConfig Formatting
tsconfig.json
Formatting-only comment/spacing adjustments; no value or behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'non-latin characters' but the actual changes only update a dependency commit reference and reformat tsconfig.json comments—neither addresses filename decoding or E2EE file opening issues. Update the title to reflect the actual changes, such as 'deps: update @rocket.chat/mobile-crypto to specific commit' or clarify if this is an incomplete PR lacking the main implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The code changes update the mobile-crypto dependency to a specific commit, which appears intended to fix filename decoding for Cyrillic characters in E2EE file attachments as required by SUP-1007.
Out of Scope Changes check ✅ Passed The tsconfig.json changes are formatting-only adjustments with no functional impact. The package.json dependency update is directly related to fixing the Cyrillic filename issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build March 16, 2026 14:12 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build March 16, 2026 14:12 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 16, 2026 14:12 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android March 16, 2026 14:43 — with GitHub Actions Error
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.71.0.108371

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTz597vp7ZL9uyIhl59w68W-4gwOvuolfHlCLcGNNkGir7ete3cVqHW0M28KjHvHlEz_WrYMuexmGismb6_

@Rohit3523 Rohit3523 force-pushed the file-name-encoding branch from a1667e3 to 21be7fe Compare March 16, 2026 15:08
@github-actions
Copy link

iOS Build Available

Rocket.Chat Experimental 4.71.0.108373

@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build March 16, 2026 15:51 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build March 16, 2026 15:51 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 16, 2026 15:51 — with GitHub Actions Error
@Rohit3523 Rohit3523 marked this pull request as ready for review March 17, 2026 13:44
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build March 17, 2026 18:19 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build March 17, 2026 18:19 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 17, 2026 18:19 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android March 17, 2026 18:55 — with GitHub Actions Error
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.71.0.108385

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQctndjmU18ccwsvRLTlJD77sIfPZFoWRqJ7H-dn4AU64VPK5aXx4iFBkY082A_zdtO06D1bOS2L06fdV9c

@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build March 17, 2026 21:56 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build March 17, 2026 21:56 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 17, 2026 21:56 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android March 17, 2026 22:42 — with GitHub Actions Error
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.71.0.108389

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNR-JuIF2NRVriX_fIz0YEzyjQ1fd_JfSi1HYV6k-Mdg9hyXjLcVXpXvF9eL3LxL3acx-CWf8NxvlbtYW93z

@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build March 18, 2026 12:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 18, 2026 12:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build March 18, 2026 12:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 requested a deployment to approve_e2e_testing March 18, 2026 12:49 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_android_build March 18, 2026 12:53 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build March 18, 2026 12:53 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 requested a deployment to official_ios_build March 18, 2026 12:53 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build March 18, 2026 12:53 — with GitHub Actions Inactive
@github-actions
Copy link

iOS Build Available

Rocket.Chat Experimental 4.71.0.108394

@Rohit3523 Rohit3523 requested a deployment to upload_experimental_android March 18, 2026 13:35 — with GitHub Actions Waiting
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.71.0.108393

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSTvHtiYZr4MmN5qc3Hw0Qsvs1qfVXCSdroM_idorVvSAwjupIyxNXiHhKN-3ohKi86yvBjsu8u8MlCV2g8

@diegolmello diegolmello changed the title fix: files with cyrillic characters fails to open fix: files with non-latin characters fails to open Mar 18, 2026
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved!

@Rohit3523 Rohit3523 merged commit 115fa79 into develop Mar 19, 2026
12 of 16 checks passed
@Rohit3523 Rohit3523 deleted the file-name-encoding branch March 19, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants