chore: Virtualized main room message list#39490
chore: Virtualized main room message list#39490MartinSchoeler wants to merge 1 commit intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| await this.add('Message_VirtualList_MaxRendered', 50, { | ||
| type: 'int', | ||
| public: true, | ||
| i18nDescription: 'Message_VirtualList_MaxRendered_Description', | ||
| }); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39490 +/- ##
===========================================
+ Coverage 70.87% 70.91% +0.03%
===========================================
Files 3196 3197 +1
Lines 113288 113322 +34
Branches 20531 20491 -40
===========================================
+ Hits 80294 80357 +63
+ Misses 30943 30918 -25
+ Partials 2051 2047 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Proof of concept of a MessageList component virtualization using Tanstack virtual
Known issues
No virtualization
https://github.com/user-attachments/assets/9aeb722c-cb75-4d4d-b091-d28593be2234
With virtualization
https://github.com/user-attachments/assets/cc2a1b64-cbc7-4b63-89f0-7e47c80001a4
Issue(s)
closes #31
CORE-1505