Skip to content

chore: Virtualized main room message list#39490

Draft
MartinSchoeler wants to merge 1 commit intodevelopfrom
poc/virtualize-msg-list
Draft

chore: Virtualized main room message list#39490
MartinSchoeler wants to merge 1 commit intodevelopfrom
poc/virtualize-msg-list

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Mar 9, 2026

Proposed changes (including videos or screenshots)

Proof of concept of a MessageList component virtualization using Tanstack virtual

Known issues

  • Jump to message behaving erratically
  • Sometimes the scroll position flickers quickly while loading more messages
  • When changing channels the scroll position is not recovered

No virtualization
https://github.com/user-attachments/assets/9aeb722c-cb75-4d4d-b091-d28593be2234

With virtualization
https://github.com/user-attachments/assets/cc2a1b64-cbc7-4b63-89f0-7e47c80001a4

Issue(s)

closes #31
CORE-1505

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 9, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 0bc46e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bdc6be19-8163-4ff8-83be-989b9448c93f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment on lines +139 to +143
await this.add('Message_VirtualList_MaxRendered', 50, {
type: 'int',
public: true,
i18nDescription: 'Message_VirtualList_MaxRendered_Description',
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.91%. Comparing base (692a891) to head (0bc46e6).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #39490      +/-   ##
===========================================
+ Coverage    70.87%   70.91%   +0.03%     
===========================================
  Files         3196     3197       +1     
  Lines       113288   113322      +34     
  Branches     20531    20491      -40     
===========================================
+ Hits         80294    80357      +63     
+ Misses       30943    30918      -25     
+ Partials      2051     2047       -4     
Flag Coverage Δ
unit 71.65% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep removing old messages from the DOM, until user scrolls up again.

2 participants