Autoload Helper Modules & Spec Cleanup #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OutlawAndy
commented
Oct 9, 2025
| run_bundle | ||
|
|
||
| gem_group :test do | ||
| gem 'capybara' |
Member
Author
There was a problem hiding this comment.
This is a default dependency in new Rails apps
…ss-strict version requirement for RMR
OutlawAndy
commented
Oct 9, 2025
| cd example_rails7 | ||
|
|
||
| bundle add --group development --path '..' rolemodel_rails | ||
| bundle add --group development --path '..' --version '> 0.20' rolemodel_rails |
Member
Author
There was a problem hiding this comment.
without an explicit --version option, bundler strictly assigns the latest version. That means the example apps have to be regenerated with every version bump. I could be convinced that is something we want, but it's not very convenient or user friendly..
wesrich
approved these changes
Oct 9, 2025
| @@ -1 +1 @@ | |||
| 3.2.2 | |||
| 3.4.4 | |||
Contributor
There was a problem hiding this comment.
No big deal, but this could be 3.4.6 🤷
|
|
||
| # Make sure RUBY_VERSION matches the Ruby version in .ruby-version | ||
| ARG RUBY_VERSION=3.2.2 | ||
| ARG RUBY_VERSION=3.4.4 |
| @@ -1 +1 @@ | |||
| 3.2.2 | |||
| 3.4.4 | |||
Contributor
There was a problem hiding this comment.
I guess this app in both places too?
Member
Author
There was a problem hiding this comment.
I'm not actually sure why these are generated in the first place.. Rbenv generally works by way of inheritance..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This is more general cleanup & boilerplate elimination.
What Changed
What changed in this PR?
Pre-merge checklist
lib/rolemodel_rails/version.rb