Improved PermissionResolver and added support for LuckPerms #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'm sorry for the delay, I haven't had much time lately, I had to catch up on a lot of things, I'm still wondering in what form we can implement it, but the assumptions are good |
|
I guess we should be able to refer to adding dependencies on litecommands-luckperms and luckperms-api like litecommands-adventure-platform does, and then set the PermissionResolver in the platform's settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily adds permission check support to Fabric. Since Fabric API lacks an API for permission validation, I moved the PermissionResolver to the core module, as it is used by both platforms (Minestom and Fabric). I also added a new
litecommands-luckpermsmodule that depends onluckperms-apito implement the PermissionResolver interface, enabling LuckPerms-based permission checks through this module.The reason for this PR is that I discovered Fabric can only implement
hasPermissionvia Mixin.