Skip to content

Commit

Permalink
Remove dist from git
Browse files Browse the repository at this point in the history
Since it is no longer in git, build it in prepublish.
Update contributing docs to reflect this.
References FormidableLabs#471.
  • Loading branch information
ianobermiller committed Dec 29, 2015
1 parent 504ed04 commit e121b73
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
_site
coverage
dist
lib
node_modules
npm-debug.log
13 changes: 4 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,10 @@ Thanks for taking the time to help us make Radium even better! Before you go ahe
- Run lint using `npm run lint`
- Run flow using `flow`

## Dist

Please do not commit changes to files in `dist`. These files are only committed when we tag releases.

## Releasing a new version to NPM (only for project administrators):

1. Update `CHANGELOG.md`, following format for previous versions
2. Run `npm run dist` to generate the dist builds
3. Commit as "Prepare for version 0.XX.Y"
4. Run `npm version patch` to update `package.json` and add a tag
5. Run `npm publish` to run tests and lint, build the `lib` directory, and publish to NPM if all is well
6. Run `git push && git push --tags`
2. Commit as "Changelog for version 0.XX.Y"
3. Run `npm version patch` (or `minor`, `major` as appropriate) to update `package.json` and add a tag
4. Run `npm publish` to run tests and lint, build the `lib` ands `dist` directories, and publish to NPM if all is well
5. Run `git push && git push --tags`
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"lib": "npm run babel && rimraf lib/__tests__ lib/__mocks__",
"lint": "eslint src && npm run flow",
"postinstall": "cd lib || npm run lib",
"prepublish": "npm test && npm run lint && npm run lib",
"prepublish": "npm test && npm run lint && npm run lib && npm run dist",
"start": "./node_modules/.bin/babel-node examples/server.js",
"test": "karma start",
"test-coverage": "karma start karma.conf.coverage.js",
Expand Down

0 comments on commit e121b73

Please sign in to comment.