Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOTP support #119

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Add TOTP support #119

merged 3 commits into from
Jul 6, 2024

Conversation

D-VR
Copy link
Collaborator

@D-VR D-VR commented Jul 3, 2024

I have added TOTP support and some error handling.

Might have missed something though, so feel free to give feedback / test it out.

Closes #118

@D-VR
Copy link
Collaborator Author

D-VR commented Jul 3, 2024

Don't know why the check is failing, the [ is matched.

[ the ](error: cannot format /home/runner/work/syncMyMoodle/syncMyMoodle/syncmymoodle/__main__.py: cannot use --safe with this file; failed to parse source file AST: f-string: unmatched '[' (<unknown>, line 250))

Edit: it's because of nested double quotes! Adding fix.

@Romern Romern merged commit 2302dd8 into Romern:master Jul 6, 2024
1 check passed
@Romern
Copy link
Owner

Romern commented Jul 6, 2024

Thank you!

@mainrs
Copy link

mainrs commented Aug 22, 2024

How exactly is this supposed to work? I added the serial number of the token generator (authenticator app) to the config field totp. But I still get the following error message:

$ python -m syncmymoodle                 
Logging in...
CRITICAL:__main__:Failed to login! Maybe your login-info was wrong or the RWTH-Servers have difficulties, see https://maintenance.rz.rwth-aachen.de/ticket/status/messages . For more info use the --verbose argument.

Edit: Nevermind, forgot to pull the newest changes!

@D-VR
Copy link
Collaborator Author

D-VR commented Aug 25, 2024

How exactly is this supposed to work? I added the serial number of the token generator (authenticator app) to the config field totp. But I still get the following error message:

$ python -m syncmymoodle                 
Logging in...
CRITICAL:__main__:Failed to login! Maybe your login-info was wrong or the RWTH-Servers have difficulties, see https://maintenance.rz.rwth-aachen.de/ticket/status/messages . For more info use the --verbose argument.

Edit: Nevermind, forgot to pull the newest changes!

Yeah forgot to update the version, so the pip install doesn't have the most current version, installing from git will have the totp generator support (current pip version only has manual totp support)

Currently RWTH is down anyways, so it will fail regardless 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Factor Authentication
3 participants