DAO468 & DAO469: depositAndDelegate & transferAndDelegate functions with tests #14
+379
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenshin
requested review from
rodrigoncalves,
Freshenext,
TravellerOnTheRun,
jessgusclark and
sleyter93
TravellerOnTheRun
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
stRIFsmart contract create 3 new public functions:depositAndDelegate: to stake RIFs to stRIFs + delegate to same address in one txtransferAndDelegate: to transfer stRifs to another account + delegate to same address in one txtransferFromAndDelegate: the same thing including prior approvalWhy
This functions will allow users to stake/transfer and delegate within a single transaction
Ref
DAO-468
DAO-469
Comment
Sorry for 2 tickets within one PR, but all functions are very closely tied together and can hardly be separated