TOK-579: change backer est. reward tooltip text #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jurajpiar
force-pushed
the
TOK-579/estimated_reward_tooltip_text
branch
from
98c394f to
0fc9ac8
Compare
franciscotobar
requested changes
Feb 5, 2025
antomor
changed the title
antomor
reviewed
Feb 5, 2025
antomor
requested changes
Feb 5, 2025
There was a problem hiding this comment.
@jurajpiar couldn't we create a single component for the tooltip being it the same?
Also, for the tooltip visibility, I'd change the overflow of the table to set it as visible
jurajpiar
force-pushed
the
TOK-579/estimated_reward_tooltip_text
branch
from
0fc9ac8 to
0277640
Compare
jurajpiar
force-pushed
the
TOK-579/estimated_reward_tooltip_text
branch
from
0277640 to
b8acbd9
Compare
antomor
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Apparently the whole text isn't exactly the same, but it's slightly different. Could you please double-check it?
antomor
approved these changes
Feb 7, 2025
jurajpiar
added a commit
that referenced
this pull request
Feb 14, 2025
* chore(cr): change backer est. reward tooltip text * fix: make overflow visible * chore(cr): change backer est. reward tooltip text * fix: remove unused component --------- Co-authored-by: Antonio <antonio@iovlabs.org>
jurajpiar
added a commit
that referenced
this pull request
Feb 17, 2025
* chore(cr): change backer est. reward tooltip text * fix: make overflow visible * chore(cr): change backer est. reward tooltip text * fix: remove unused component --------- Co-authored-by: Antonio <antonio@iovlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the backer rewards estimated rewards tooltip text.
Note
The table tooltip is not fully shown. This is outside of the scope of the ticket, unless requested to be in.
Task