Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOK-611: migration-support #666

Merged
merged 10 commits into from
Feb 14, 2025
Merged

TOK-611: migration-support #666

merged 10 commits into from
Feb 14, 2025

Conversation

franciscotobar
Copy link
Contributor

@franciscotobar franciscotobar commented Feb 11, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@franciscotobar franciscotobar force-pushed the TOK-611/migration-support branch from 9ffdda6 to 359353c Compare February 11, 2025 03:06
@franciscotobar franciscotobar requested a review from a team February 11, 2025 03:08
@franciscotobar franciscotobar marked this pull request as ready for review February 11, 2025 03:08
@franciscotobar
Copy link
Contributor Author

There are still some topics to discuss, but it's going to be easy with the PR ready :)

@franciscotobar franciscotobar changed the title feat: migration support TOK-611/migration-support Feb 11, 2025
antomor
antomor requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments I've left. Shouldn't we change also useGetBuilderToGauge here?

@antomor antomor changed the title TOK-611/migration-support TOK-611: migration-support Feb 11, 2025
@franciscotobar franciscotobar force-pushed the TOK-611/migration-support branch from 28475c4 to f241b6b Compare February 11, 2025 22:59
antomor
antomor approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscotobar franciscotobar force-pushed the TOK-611/migration-support branch 3 times, most recently from 9e9eb67 to b7ad24d Compare February 13, 2025 17:19
@franciscotobar franciscotobar force-pushed the TOK-611/migration-support branch from 12780eb to 2479c7a Compare February 14, 2025 05:30
@franciscotobar franciscotobar force-pushed the TOK-611/migration-support branch from 2479c7a to 8229030 Compare February 14, 2025 05:33
@franciscotobar franciscotobar merged commit 8bffe86 into develop Feb 14, 2025
8 checks passed
@franciscotobar franciscotobar deleted the TOK-611/migration-support branch February 14, 2025 18:07
jurajpiar pushed a commit that referenced this pull request Feb 17, 2025
@franciscotobar @jurajpiar
TOK-611: migration-support (#666)
cb6bcb2 
* feat: migration support

* refactor: pr comments

* refactor: first request

* refactor: rename

* refactor: env variables

* fix: backer reward percentage

* refactor: backers manager abi

* fix(BackerRewards): can manage allocations

* builder: env for migration

* fix: encoded builder registry address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
collective-rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscotobar @antomor @javicoin