Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VoteCast event fetching #669

Merged
merged 7 commits into from
Feb 12, 2025
Merged

feat: VoteCast event fetching #669

merged 7 commits into from
Feb 12, 2025

Conversation

TravellerOnTheRun
Copy link
Contributor

@TravellerOnTheRun TravellerOnTheRun commented Feb 11, 2025

For those wondering "Why not use our RIF_WALLET_SERVICES?". The reason is simple it does not support topic1 and I tried adding it there, for the reason of saving time and both of DAO-1061 and DAO-1062 being a dependency of DAO-1015 which needs to be shipped this Thursday, I decided to go with what works.

@TravellerOnTheRun TravellerOnTheRun requested a review from a team February 11, 2025 05:27
@TravellerOnTheRun TravellerOnTheRun self-assigned this Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@TravellerOnTheRun TravellerOnTheRun added the urgent This label indicates that this PR is a dependency of others or needs to be merged quicker label Feb 11, 2025
Copy link
Contributor

@rodrigoncalves rodrigoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change.

Freshenext
Freshenext previously approved these changes Feb 11, 2025
Copy link
Contributor

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by mistake 😁

This PR RootstockCollective/dao-backend-services#27 has been merged - pending updating

@Freshenext Freshenext self-requested a review February 11, 2025 18:05
@Freshenext Freshenext dismissed their stale review February 11, 2025 18:06

Not yet to be merged

Copy link
Contributor

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should be good :D

@TravellerOnTheRun TravellerOnTheRun merged commit b956c51 into develop Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge urgent This label indicates that this PR is a dependency of others or needs to be merged quicker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants