refactor: make sure that balances and prices change independently #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravellerOnTheRun
requested review from
rodrigoncalves,
shenshin and
Freshenext
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Freshenext
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
This is OK in terms of code.
What I am afraid is that balances or prices are changing
And that will cause the entire context to trigger a re-render
We might be better splitting that context even more to have balances somewhere and prices elsewhere
An investigation has to be done to see how frequent these two change to potentially implement a better solution; but this one is OK assuming that both variables don't change that much
rodrigoncalves
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution to be too simple to be true, but I verified with a couple of Stack Overflow threads, looks solid.