Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this script matches AJ's best relax flavor from SRC 2020 #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smlewis
Copy link
Member

@smlewis smlewis commented Aug 20, 2020

Not going to merge without her explicit permission but I'll put it here for comment (it was discussed in slack yesterday)

@AJVincelli
Copy link
Member

Thank you Steven! This would have taken me... a really long time... to write. I will test out this script and see if it performs similarly to the command-line version that I presented at SRC 2020, and report back. Give me... some time.

@AJVincelli
Copy link
Member

Note that @danielzaidman recently reported that this script results in a slightly misaligned pose, which might affect RMSD. I will also look into this.

@danielzaidman
Copy link
Member

I'm still not sure why (looking into it), but as it is at the moment, the result of this script is definitely different than "java", even after aligning the chains back. Java is much more conservative with the backbone. @smlewis @AJVincelli

@danielzaidman
Copy link
Member

Hey @smlewis , @AJVincelli . I added a missing line, and now the output looks the same as "java". I think we can merge now.

@roccomoretti
Copy link
Member

I think this is entirely @AJVincelli's call as to whether this script properly represents her best-practices settings. I don't see anything immediately at issue with it, but I don't have the full flag-set for Java with me at the moment, so I can't double check.

@smlewis
Copy link
Member Author

smlewis commented Sep 30, 2020

It definitely shouldn't merge until closer to her paper.

@AJVincelli
Copy link
Member

Well, the good news is that I'm working on Relax things... The bad news is that I haven't gotten to testing this script yet. I'm probably ~1 month away from testing and comparing with previous results. Even if the manuscript isn't mature and it won't be a good time to merge, I can still report back with a stamp of approval. Is that timeline acceptable?

@AJVincelli
Copy link
Member

The main Java flags are -constrain_relax_to_start_coords -relax:ramp_constraints false -relax:script MonomerRelax2019 (I think Daniel's small fix added the MonomerRelax2019 equivalent?). And technically, Java uses -nstruct 5 (and -in:file:fullatom but I don't know if that actually does anything).

Copy link
Member

@AJVincelli AJVincelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the scripts_to_parse.py file, is the / at the beginning of /scripts/public/preparation/constrained_relax.xml intentional?

@AJVincelli
Copy link
Member

Hm, I'm getting an error when I include the commandline flag -out:mmCIF. I've asked Slack how I can specify a CIF file output using RosettaScripts. I'll post back when I have updates...

@AJVincelli
Copy link
Member

It appears that the -out:mmCIF flag should work. Can anybody get this script to run with the -out:mmCIF flag?

@AJVincelli
Copy link
Member

Rocco helped me debug the issue with -out:mmCIF. If I also add the flag -out::file::output_pose_cache_data false, it works! I will now test this script on my 500-structure dataset, and report back if it works as expected and reproduces my previous results. (Can you tell that I'm trying to get this before RosettaCON??)

@roccomoretti
Copy link
Member

The issue with -out:mmCIF is RosettaCommons/main#5503

@AJVincelli
Copy link
Member

Hi all, I've (finally!) tested this script with my benchmark dataset, and it works beautifully with Daniel's small fix and the -out::file::output_pose_cache_data false flag. I also removed the / at the beginning of the /scripts/public/preparation/constrained_relax.xml line (see above), I'm not sure if that matters. I'm hoping to write up the manuscript this autumn, so we're getting closer to merging...

@weitzner
Copy link
Member

It seems interesting that there is not any cartesian space minimization used here. Was that tested as part of this work?

@AJVincelli
Copy link
Member

AJVincelli commented Nov 29, 2021

Hi @weitzner, yes! All of the juicy details are here: http://bit.ly/BestRelaxMethod I was surprised to find that Cartesian Relax didn’t improve the Quality Scores as much (such as the Latte flavor).

@weitzner
Copy link
Member

weitzner commented Dec 2, 2021

Interesting! Thanks for passing the doc along!

@AJVincelli
Copy link
Member

AJVincelli commented Dec 2, 2021 via email

@ajasja
Copy link
Member

ajasja commented Mar 4, 2024

@AJVincelli How are things going? Do you have plans to merge this? I guess it has to go into the new repo now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants