Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report header regex for shorter contract names #182

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix report header regex for shorter contract names #182

merged 2 commits into from
Jun 10, 2024

Conversation

Kebiled
Copy link
Contributor

@Kebiled Kebiled commented May 27, 2024

Description

reportHeaderRegex was set up to only allow for one space between the contract and the ending pipe char |.

On some contracts with shorter names, and longer method names, there will be more than one space in the forge tests tables formatting.

Example output from my forge test:

| src/Shop.sol:Shop contract     |

This will cause the action to ignore these tables when gathering info from the reports.

I've changed the regex to allow for any number of whitespace characters after contract with /^\| .+:.+ contract +\|/

Rubilmax
Rubilmax previously approved these changes May 28, 2024
Copy link
Owner

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, releasing a new patch version for this specifically!

@Rubilmax
Copy link
Owner

Rubilmax commented May 28, 2024

I simply need you to pull main and update this PR by running yarn && yarn release again (I bumped the action's dependencies because they weren't for a long time)

Or I'll merge the changes myself but having you as a contributor of this repository is good!

@Kebiled
Copy link
Contributor Author

Kebiled commented May 30, 2024

Thanks! Will get that done tomorrow

@Kebiled
Copy link
Contributor Author

Kebiled commented Jun 10, 2024

@Rubilmax FYI, sorted issue

@Rubilmax Rubilmax merged commit c265a31 into Rubilmax:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants