Remove unnecessary closures #451
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c410-f3r
requested review from
Firestar99,
LegNeato,
eddyb and
schell
as code owners
LegNeato
approved these changes
Oct 27, 2025
eddyb
reviewed
Oct 28, 2025
Comment on lines
-36
to
+37
| .map(|s| s.to_string()) | ||
| .map(ToString::to_string) |
There was a problem hiding this comment.
Apropos of nothing, Lean4 has a cute syntax for this I wish more languages had:
.map(·.to_string())(based on a quick GitHub search, they literally have (·.toString) for their equivalent of the Rust |x| x.to_string())
There's a few others, I think Perl is one, but it's not as common as it could be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to provide some contributions to the project.
Looking at the issues alone didn't provide enough context so I shamelessly went ahead with
redundant_closure_for_method_calls, which is trivial to review and accept :)Feel free to indicate more things that are feasible/solvable for someone new.
Cheers