Don't call AudioObjectGetPropertyData again if CFStringGetCStringPtr fails #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails. There's no indication that CFStringGetCStringPtr failing is destructive for the CFString: https://developer.apple.com/documentation/corefoundation/1542133-cfstringgetcstringptr
|
I tested this and seems to be right. Maybe it could get merged? It's a minor thing, but it would be nice! |
|
No part of this code (that I could find) is still present in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no indication that
CFStringGetCStringPtrfailing is destructive for theCFString:https://developer.apple.com/documentation/corefoundation/1542133-cfstringgetcstringptr
So calling
AudioObjectGetPropertyDataa second time to get the device name isn't necessary.It looks like this was an unintentional error in #399, but I don't have a wide-character install of macOS to try this against (to check that it doesn't regress #398).
cc @thavlik