Add HC-128 and Fix HC-256 #283
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase and update this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219 This implementation of HC-128 does not yet have the test vectors. HC-256 was using a table size of 2660 instead of 2560, this does not cause issue with the generated key stream, but slightly lengthens the initialization time. The function
h2in HC-256 usedself.ptableinstead ofself.qtable, this means that it does not apply linear masking when the stream is usingh2. For inputs that never get output fromh2it gives the correct results, but onceh2is in use the values are incorrect.