Remove ChaChaXCore types #512
Conversation
| } | ||
| } | ||
| impl CryptoGenerator for $ChaChaXCore {} | ||
| impl CryptoGenerator for ChaChaCore<$rounds, Legacy> {} |
There was a problem hiding this comment.
If the field will be private this impl can be removed.
There was a problem hiding this comment.
The point being that we don't need trait CryptoGenerator at all. The trait is (I believe) only used by ReseedingRng, so lets start with that.
|
I think it better to merge this then make a new PR for rust-random/rand_core#68. |
|
Aside: it would be nice to expose the What is the preferred way to do this — a simple unparametrised method? Or provide a copy of |
|
I think we can add public inherent methods and then use them in implementation of |
|
Yeah, just add an inherent method with the same name/type signature as the trait. You can always disambiguate via UFCS |
3 participants
In discussion of API bloat with @newpavlov, it became clear that we don't need these types.
The only known use is
rand::rngs::ThreadRng, yet there's no reason that can't useChaChaCore(already a public item).