Skip to content

Multi-select functionality for wall views #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RyanAtNight wants to merge 8 commits into from
Closed

Multi-select functionality for wall views #1

RyanAtNight wants to merge 8 commits into from

Conversation

@RyanAtNight
Copy link
Owner

@RyanAtNight RyanAtNight commented Jan 5, 2026 •
edited
Loading

Summary of Changes

New Features

  • Add selecting mode to wall views (Scenes, Scene Markers, Images, Galleries)
  • Implement checkbox-based selection for wall items across all wall view types
  • Support for multi-select interactions with Shift+Click

Bug Fixes

  • Fix text selection bug in wall view multi-select - When selecting items with checkboxes and clicking/dragging, text overlay is no longer selected
    • Made wall items draggable when in selection mode to prevent browser text selection interference
    • Applied consistent pattern used in grid view (HTML5 draggable attribute prevents text selection as side effect)
  • Fix CSS property ordering in wall-item-check component
  • Fix destructuring lint error in ImageList component

Code Quality

  • Refactor: remove unnecessary imageId duplication and type casting

Test Plan

  1. Navigate to wall view (Scenes, Images, Galleries, or Scene Markers)
  2. Verify checkbox selection works correctly on individual items
  3. Select one item by clicking its checkbox
  4. Click and drag across wall items - verify text overlay is NOT selected
  5. Verify multi-select functionality with Shift+Click for ranges
  6. Verify all linter checks pass (0 errors)
  7. Verify application builds and runs without errors

WithoutPants and others added 7 commits January 5, 2026 11:28
@WithoutPants
Safely handle panic in scan queue goroutine (stashapp#6431)
08b8743
@WithoutPants
Custom favicon and title (stashapp#6366)
d962247 
* Load favicon if provided
* Add custom title setting
@RyanAtNight
Add selecting mode to wall views
36c69a2
@RyanAtNight
Fix destructuring lint error in ImageList
f9d3df4
@RyanAtNight
Fix CSS property ordering in wall-item-check
1755f32
@RyanAtNight
refactor: remove unnecessary imageId duplication and type casting
c52e615 
- Remove duplicate imageId property from photos array (use existing key instead)
- Remove module augmentation for react-photo-gallery Photo type
- Replace 'as unknown as' type cast with direct access to props.photo.key
- Add null check for imageId to handle optional key property
- Eliminates code smell and improves type safety
@RyanAtNight
Fix text selection bug in wall view multi-select by making items drag…
5ad5bda 
…gable in selection mode
@RyanAtNight RyanAtNight changed the title Fix text selection bug in wall view multi-select Multi-select functionality for wall views Jan 5, 2026
@RyanAtNight RyanAtNight force-pushed the feature/wall-view-multi-select branch from 44d932c to 50b4174 Compare January 5, 2026 03:53
@RyanAtNight RyanAtNight closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RyanAtNight @WithoutPants