Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to setup hotkeys to cycle through controllers #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SomeoneIsWorking
Copy link

@SomeoneIsWorking SomeoneIsWorking commented Nov 2, 2024

What this does is you can add/remove hotkeys for players to cycle through controllers.
Reasons I made this.

  • Sometimes Player 1 is set to disabled by itself (when started with controller off, Isaac had a fix PR for this but I don't know if it's implemented).
  • My son sometimes plays co-op with a single controller and sometimes plays co-op with us so we can cycle Player 2 based on it.
  • On ROG Ally, I can easily switch between handheld controller and external controller.

KNOWN ISSUES

  • Toast message not displaying when game is being rendered. I don't know how to fix it. I think it's related to Avalonia and the render component and the render component is rendering on top of the toast.

NOTES

  • Hotkeys don't work before starting a game. The only time where both this works and the toast is visible is if you press it while the emulator is loading the game. The keys will work during gameplay but toast won't be visible due to the issue.

UPDATES NEEDED

  • "Player X" isn't localized.
  • Layout could be better.

POSSIBLE OTHER UPDATES

  • Currently this relies on calling a ViewModel because controller logic is tied into it which is not 100% ideal so maybe that can be decoupled.

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Nov 2, 2024
@VeraPhobia
Copy link

i downloaded the artifact but i cant find the option to test it out

image

@SomeoneIsWorking
Copy link
Author

SomeoneIsWorking commented Nov 3, 2024

@VeraPhobia Yes, I just noticed, I think I messed up the rebase and I can't get the code back anymore so I'll try to do it again.

Edit: Thank VSCode local history, I was able to restore it.

image

This is how it should look like now.

@VeraPhobia
Copy link

extremely minor details but it would look better if the text and fields were in one line, right now they are kind of not.

and thank you for the great work

@SomeoneIsWorking
Copy link
Author

Okay, I got some drops of motivation to update it, also like to play with Copilot Edits.

@SomeoneIsWorking SomeoneIsWorking force-pushed the feature/input-switch branch 3 times, most recently from b969e37 to 1d4e578 Compare December 22, 2024 20:57
@SomeoneIsWorking
Copy link
Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants