Replace 'Expand DRAM' option with dropdown menu #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
gui
KeatonTheBot
changed the title
GreemDev
requested changes
Oct 21, 2024
| @@ -245,7 +246,7 @@ public class ConfigurationFileFormat | |||
| /// <summary> | |||
| /// Expands the RAM amount on the emulated system from 4GiB to 8GiB | |||
| /// </summary> | |||
| public bool ExpandRam { get; set; } | |||
| public MemoryConfiguration DramSize { get; set; } | |||
There was a problem hiding this comment.
The version at the top of this class needs to be updated to reflect changes in the structure of the config; and migration code needs to be added similar to how it's done here
| @@ -98,7 +98,6 @@ public static bool CanStartApplication(ContentManager contentManager, string bas | |||
| if (baseApplicationExtension is not (".nro" or ".nso")) | |||
| return IsFirmwareValid(contentManager, out error); | |||
|
|
|||
| error = UserError.Success; | |||
There was a problem hiding this comment.
The note on the above if is the reason for this line being there
KeatonTheBot
force-pushed
the
dram-dropdown
branch
from
1c26ca3 to
0f3c7f9
Compare
WilliamWsyHK
pushed a commit
to WilliamWsyHK/Ryujinx-Ryubing
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dropdown menu replaces the 'Expand DRAM to 8GiB' option under Settings/System/Hacks. Configurable to use 4GiB (default), 6GiB, 8GiB, and 12GiB. The latter is needed for some really heavy duty 8K+ native resolution mods, and 6GiB/8GiB should be fine for most 4K+ mods (mirroring the OG Switch and Switch OLED dev kits, respectively).